-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
Update basic_maths.py #6017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update basic_maths.py #6017
Conversation
Please add a test that fails under the current code but passes under the new code so we have proof that this change is really needed. |
Old Code: |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@nivid26 This actually looks correct. Would you be able to add a few tests to cover this? |
In the following files, few significant included where previous version of basic_maths.py is failed compute correct result of code and also included the correct output generated by modified version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.