Skip to content

ci: add mkdir step for mypy #5927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2022
Merged

ci: add mkdir step for mypy #5927

merged 2 commits into from
Jan 26, 2022

Conversation

MichaelCurrin
Copy link
Contributor

Describe your change:

When running with no cache the first time, mypy fails to get missing imports because the cache is missing.

An empty cache solves the issue.

#5917 (comment)

  • Fix CI flow for new contributors
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@MichaelCurrin MichaelCurrin mentioned this pull request Jan 17, 2022
Merged
14 tasks
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jan 17, 2022
poyea
poyea approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jan 26, 2022
@poyea poyea merged commit 7423875 into TheAlgorithms:master Jan 26, 2022
@poyea
Copy link
Member

poyea commented Jan 26, 2022

Rebase #5917 as this is merged.

@MichaelCurrin MichaelCurrin deleted the ci-add-mypy-cache-dir-to-workflow branch January 26, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelCurrin @poyea