-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Remove duplicate is_prime related functions #5892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update ciphers.rabin_miller.py maths.miller_rabin.py
Hi @Kush1101! |
… project_euler's isPrime to is_prime function names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poyea, I solved the pro-commit hook problem and I'm submitting the changes that you requested, for review now.
@poyea, I guess that we have the egg and chicken problem here... This pre-commit workflow is breaking on this definition
Then, when I change the code, the pyupgrade module revert it to the original and the flake8 module returns the same error:
But I didn't even need to move this part. When I fixed the other files, this new problem has arisen. |
@paulosgf Let's check if this works? |
Yes, @poyea! Now it's Ok to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩
Fixes (#5434)
maths.miller_rabin.py
Describe your change:
Remove duplicate is_prime related functions
Checklist:
Fixes: #{$ISSUE_NO}
.