Skip to content

Added memoization function in fibonacci #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2021
Merged

Added memoization function in fibonacci #5856

merged 2 commits into from
Nov 28, 2021

Conversation

JDeepD
Copy link
Contributor

@JDeepD JDeepD commented Nov 28, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@JDeepD JDeepD requested a review from Kush1101 as a code owner November 28, 2021 13:53
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 28, 2021
@JDeepD JDeepD mentioned this pull request Nov 28, 2021
Closed
14 tasks
andrei-polukhin
andrei-polukhin suggested changes Nov 28, 2021
View reviewed changes
Copy link

@andrei-polukhin andrei-polukhin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very well overall, just fix one comment.
Edit: forgot one moment, see the latest review

andrei-polukhin
andrei-polukhin approved these changes Nov 28, 2021
View reviewed changes
Copy link

@andrei-polukhin andrei-polukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine

@andrei-polukhin
Copy link

@JDeepD Looks well for me, ask for review people with write access to repo such as @Kush1101 and @cclauss

@cclauss
Copy link
Member

cclauss commented Nov 28, 2021

Please use the same tests as the other implementations. Please put the test results in the docstring at the top of the file so that visitors can see at a glance how these algorithms perform.

@JDeepD
Copy link
Contributor Author

JDeepD commented Nov 28, 2021 •
edited
Loading

Please use the same tests as the other implementations.

Like, should I output a list of n fibonacci numbers??

@cclauss
Copy link
Member

cclauss commented Nov 28, 2021 •
edited
Loading

The doctests should be the same for all functions to ensure they all deliver the right answers.

Like run the file and paste in the text that the last four lines generate.

cclauss
cclauss approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice performance numbers! Thanks for the teamwork on this one.

@cclauss cclauss merged commit 65d3cff into TheAlgorithms:master Nov 28, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@andrei-polukhin andrei-polukhin andrei-polukhin approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JDeepD @andrei-polukhin @cclauss