Skip to content

Update merge_insertion_sort.py #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Update merge_insertion_sort.py #5833

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa599a3
Update merge_insertion_sort.py
yellowsto Nov 17, 2021
ecabcbd
Update merge_insertion_sort.py
yellowsto Nov 19, 2021
0e08304
Update merge_insertion_sort.py
yellowsto Nov 24, 2021
b0906e6
Use `all()`
poyea Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sorts/merge_insertion_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ def merge_insertion_sort(collection: list[int]) -> list[int]:

>>> merge_insertion_sort([-2, -5, -45])
[-45, -5, -2]

Testing with all permutations on range(0,5):
>>> import itertools
>>> permutations = list(itertools.permutations([0, 1, 2, 3, 4]))
>>> [x for x in permutations if merge_insertion_sort(x) != [0, 1, 2, 3, 4]]
[]
"""

def binary_search_insertion(sorted_list, item):
Expand Down Expand Up @@ -160,7 +166,7 @@ def merge(left, right):
"""
is_last_odd_item_inserted_before_this_index = False
for i in range(len(sorted_list_2d) - 1):
if result[i] == collection[-i]:
if result[i] == collection[-1] and has_last_odd_item:
is_last_odd_item_inserted_before_this_index = True
pivot = sorted_list_2d[i][1]
# If last_odd_item is inserted before the item's index,
Expand Down