Skip to content

Add missing type annotations for strings directory #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 13, 2022
Merged

Add missing type annotations for strings directory #5817

merged 12 commits into from
May 13, 2022

Conversation

Rohanrbharadwaj
Copy link
Contributor

@Rohanrbharadwaj Rohanrbharadwaj commented Nov 11, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Nov 11, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 11, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title Type annotations for strings/autocomplete_using_trie.py Type annotations for some files in strings Nov 11, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 11, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 11, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 11, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 11, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title Type annotations for some files in strings Add type annotations for strings directory Nov 11, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 11, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 11, 2021
@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Nov 11, 2021
@Rohanrbharadwaj Rohanrbharadwaj changed the title Add type annotations for strings directory Add missing type annotations for strings directory Nov 11, 2021
@stale
Copy link

stale bot commented Apr 19, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 19, 2022
@poyea poyea self-assigned this May 12, 2022
poyea
poyea approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 13, 2022
@stale stale bot removed the stale Used to mark an issue or pull request stale. label May 13, 2022
@poyea poyea merged commit e95ecfa into TheAlgorithms:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rohanrbharadwaj @poyea