Skip to content

Improve Project Euler problem 074 solution 2 #5803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Improve Project Euler problem 074 solution 2 - the top 3 slowest solution on GitHub Actions logs (under slowest 10 durations: 13.77s call scripts/validate_solutions.py::test_project_euler[problem_074/sol2.py]):

  • Fix statement

  • Improve solution (locally 7+ times - from 14+ seconds to ~2 seconds)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Nov 10, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 10, 2021
@cclauss
Copy link
Member

cclauss commented Nov 10, 2021

Please test how the functions deal with 0, negative numbers, floats instead of ints, etc.

@MaximSmolskiy
Copy link
Member Author

Please test how the functions deal with 0, negative numbers, floats instead of ints, etc.

Added tests

@stale
Copy link

stale bot commented Apr 19, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 19, 2022
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 12, 2022
@poyea poyea merged commit 562cf31 into TheAlgorithms:master May 12, 2022
@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-074-solution-2 branch May 12, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files stale Used to mark an issue or pull request stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants