Skip to content

Improve Project Euler problem 012 solution 1 #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Improve Project Euler problem 012 solution 1 - the top 10 slowest solution on Travis CI logs (under slowest 10 durations: 3.41s call scripts/validate_solutions.py::test_project_euler[problem_012/sol1.py]):

  • Improve solution (locally 6+ times - from 3+ seconds to ~0.5 seconds)

  • Uncomment code that has been commented due to slow execution affecting Travis (now it should be quite fast execution and not affect Travis)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 31, 2021
@MaximSmolskiy MaximSmolskiy force-pushed the improve-project-euler-problem-012-solution-1 branch from 3abbc68 to 4b015ee Compare October 31, 2021 21:17
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 31, 2021
@MaximSmolskiy MaximSmolskiy force-pushed the improve-project-euler-problem-012-solution-1 branch from 4b015ee to 026ddd0 Compare October 31, 2021 21:20
@MaximSmolskiy MaximSmolskiy mentioned this pull request Oct 31, 2021
14 tasks
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 31, 2021
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 1, 2021
@l3str4nge l3str4nge merged commit 71ba3a1 into TheAlgorithms:master Nov 1, 2021
@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-012-solution-1 branch November 1, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants