Skip to content

Add stone unit of measuring weight #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2021
Merged

Add stone unit of measuring weight #5730

merged 2 commits into from
Nov 1, 2021

Conversation

mrbrianevans
Copy link
Contributor

@mrbrianevans mrbrianevans commented Oct 31, 2021 •
edited
Loading

Describe your change:

I have added a new unit of measurement to the weight conversion algorithm. The new unit is "stone".

I've added some tests in the docs using an external calculator. Not sure if they pass.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mrbrianevans
Add stone unit of measuring weight
f378138 
And some tests in the docs using an external calculator. Not yet tested if they pass.
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 31, 2021
@mrbrianevans
Copy link
Contributor Author

Okay I've fixed the tests and they are passing on my machine, so please could you run them on the automated system for ci. Thanks

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 31, 2021
@mrbrianevans
Copy link
Contributor Author

As far as I can tell, the failing build is not due to anything related to my pull request; please could you give me more details.

When I run mypy locally on the file I changed, I get:

mypy --ignore-missing-imports conversions\weight_conversion.py
Success: no issues found in 1 source file

And the failing file in the github action is:

strings\check_anagrams.py:32: error: Need type annotation for "count"

which is unrelated to the changes I've made.

Please could you let me know what I can do to get the build passing. Thanks

@cclauss
Copy link
Member

cclauss commented Nov 1, 2021

Do you know how to rebase the pull request?

@mrbrianevans
Copy link
Contributor Author

Yes I think so, will try tomorrow. I'll let you know if I need some help. Has a fix for this build issue been pushed to the master branch?

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 1, 2021
@cclauss cclauss merged commit dc6e773 into TheAlgorithms:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbrianevans @cclauss