-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Added physical pressure units #5613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This uses tuple pair which stores units required to be converted to respective other units as mentioned. Available Units:- Pascal,Bar,Kilopascal,Megapascal,psi(pound per square inch),inHg(in mercury column),torr,atm
File was formatted as per repo rules
I did 2 conversion algorithm for the past 1 week . First one has been merged and this is the second one. |
Is there are a separate source of conversions on the internet that can confirm our results? |
I have a website , but that's not wikipedia. Shall I add it ? https://msestudent.com/what-are-the-units-of-pressure/ |
I have added reference website which has relevant unitary data . |
Alternatively you can google corresponding unitary value (like 1Pa to atm ) to evaluate multiplier needed |
I was not referring to our unitary values. I was referring to going to a website that does conversions and then putting in our doctest values to see if their conversions match ours. |
I guess to do that you may visit https://www.unitconverters.net/pressure-converter.html |
@cclauss I have added website in reference which helps in converting between pressure units directly like how you asked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doctest results match well with unitconverters.net
This uses tuple pair which stores units required to be converted to respective other units as mentioned.
Available Units:- Pascal,Bar,Kilopascal,Megapascal,psi(pound per square inch),inHg(in mercury column),torr,atm
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.