-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
mypy: Exclude only 20 files that are still failing #5608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a68cc16
DRAFT: Run a mypy reality check
cclauss 275615b
mypy --ignore-missing-imports --install-types --non-interactive
cclauss 43df758
Check our progress...
cclauss 8ced76c
Update build.yml
cclauss 5273f52
Update build.yml
cclauss c8b64a8
Update build.yml
cclauss 8ea9fab
Update build.yml
cclauss 967e1bd
mypy --exclude 20 files
cclauss 471e638
--exclude with no `=`
cclauss 14633a1
Update build.yml
cclauss f073fe7
558 character regex!!!
cclauss b0a5549
With quotes
cclauss 2d65941
mypy.ini: mega exclude
cclauss ffad6f5
Update mypy.ini
cclauss 105c1f4
Update build.yml
cclauss f972c84
Update mypy.ini
cclauss 9c621d3
Update build.yml
cclauss 0091d5c
Update mypy.ini
cclauss 9404b67
.py --> .p*
cclauss 3bfb2b6
Escape the dots!: `.` --> `\.`
cclauss dcefccb
Remove the comment
cclauss 535988e
Leading slash
cclauss 36d2c4b
Update mypy.ini
cclauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
[mypy] | ||
ignore_missing_imports = True | ||
install_types = True | ||
non_interactive = True | ||
exclude = (data_structures/stacks/next_greater_element.py|graphs/boruvka.py|graphs/breadth_first_search.py|graphs/breadth_first_search_2.py|graphs/check_cycle.py|graphs/finding_bridges.py|graphs/greedy_min_vertex_cover.py|graphs/random_graph_generator.py|maths/average_mode.py|maths/gamma_recursive.py|maths/proth_number.py|maths/series/geometric_series.py|maths/series/p_series.py|matrix_operation.py|other/fischer_yates_shuffle.py|other/least_recently_used.py|other/lfu_cache.py|other/lru_cache.py|searches/simulated_annealing.py|searches/ternary_search.py) | ||
|
||
; FIXME: #4052 fix mypy errors in the exclude directories and remove them below | ||
exclude = (data_structures|graphs|maths|matrix|other|searches)/$ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be done on multiline if possible for better readability. If not possible, then ignore this comment.