Skip to content

[mypy] Fix type annotations for data_structures/trie/trie.py #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shermanhui
Copy link
Contributor

fix mypy error in trie.py

My contribution to fixing the mypy errors identified in #4052

Screen Shot 2021-10-21 at 18 05 04

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 22, 2021
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩 This could have been combined with #5517 next time, given the size of the changes,

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 22, 2021
@poyea poyea merged commit b373c99 into TheAlgorithms:master Oct 22, 2021
@shermanhui
Copy link
Contributor Author

@poyea apologies! I was thinking of that, but I noticed that there was a checklist item for keeping PR changes to one algo file so I played it safe. 😓 I'll keep that in mind for the next PRs I make, thanks for the prompt review + merge! 😄

@poyea
Copy link
Member

poyea commented Oct 22, 2021

No worries at all! Thanks @shermanhui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants