Skip to content

Added solution for probelm_686 of project_euler #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2021
Merged

Added solution for probelm_686 of project_euler #5480

merged 4 commits into from
Oct 26, 2021

Conversation

srishtik2310
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 20, 2021
@srishtik2310
Copy link
Author

@poyea @cclauss
I am getting this error during tests.

FAILED project_euler/problem_015/sol1.py::project_euler.problem_015.sol1.solution
345
================== 1 failed, 400 passed in 285.51s (0:04:45) ===================
346
Error: Process completed with exit code 1.

I had pushed problem_686, but my tests are failing due to problem_015.
Can you help?

@poyea
Copy link
Member

poyea commented Oct 21, 2021

Yes, could you please change line 28 to

    k = n // 2

in project_euler/problem_015/sol1.py::project_euler.problem_015.sol1.solution?

@poyea
Copy link
Member

poyea commented Oct 21, 2021

Please see and wait for #5496.

@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 21, 2021
@srishtik2310
Copy link
Author

Thank you @poyea for solving #5496. Commit passed the tests.

@srishtik2310
Copy link
Author

@poyea any other changes required? Can you review the code?

poyea
poyea approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@poyea poyea merged commit b4036b7 into TheAlgorithms:master Oct 26, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srishtik2310 @poyea