Mypy check polygon and corrections #5419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
awaiting reviews
poyea
reviewed
Oct 19, 2021
maths/check_polygon.py
Outdated
| @@ -14,15 +14,27 @@ def check_polygon(nums: List) -> bool: | |||
| True | |||
| >>> check_polygon([3, 7, 13, 2]) | |||
| False | |||
| >>> check_polygon([1, 4.3, 5.2, 12.2]) | |||
| False | |||
| >>> nums = [3, 7, 13, 2];check_polygon(nums); nums | |||
There was a problem hiding this comment.
I think we can separate this into 3 lines
There was a problem hiding this comment.
I will see how this is done
poyea
reviewed
Oct 19, 2021
maths/check_polygon.py
Outdated
| nums.sort() | ||
| return nums.pop() < sum(nums) | ||
| if len(nums) < 2: | ||
| raise ValueError("List must have at least two values") |
There was a problem hiding this comment.
A digon is not a polygon in the Euclidean space I guess?
There was a problem hiding this comment.
That is quite interesting,
However I think that a message with errors like
"Monogons and Digons are not polygons in the Euclidean space" could be confusing
poyea
approved these changes
Oct 21, 2021
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Update annotations to Python 3.10 TheAlgorithms#4052 * Add floats doctest * Copy list to avoid changing input unpredictably * Refactor code to make it readable * updating DIRECTORY.md * Improve raised ValueErrors and add doctest * Split doctest in multiples lines * Change ValueError to Monogons and Digons are not poly * Correct doctest refering number of sides Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.