Add Polybius cipher #5409
Merged
Add Polybius cipher #5409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
SakshamJain7
approved these changes
Oct 18, 2021
l3str4nge
reviewed
Oct 18, 2021
| "44154344 32154343112215" | ||
| """ | ||
| message = message.lower() | ||
| message = message.replace("j", "i") |
There was a problem hiding this comment.
Why replace? Please add test for this condition
There was a problem hiding this comment.
Since there's only 25 spaces in the polybius square and 26 letters, the cipher replaces all j's in the message with i's
A test was added for this condition
|
Please also fix the build issues |
|
I'm having a lot of trouble getting the tests' syntax right, that's probably the reason for the build issues. This last commit tries to fix that, let's hope it works! |
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Add polybius cipher * Fix polybius.py build issues and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.Sorry if I shouldn't have deleted my last PR, I had some problems with my forked repository and decided to try it again from scratch (still trying to learn how to use Git). I think all the errors with the tests are fixed now.