-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
[mypy] Fix type annotations for trie.py #5022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
853906b
to
61caf1f
Compare
7f05a98
to
e5135ce
Compare
e5135ce
to
a3f5a97
Compare
poyea
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!🤩Let's make it --strict
?
> mypy . --ignore-missing-imports --strict
trie.py:10: error: Function is missing a return type annotation
trie.py:10: note: Use "-> None" if function does not return a value
trie.py:14: error: Function is missing a return type annotation
trie.py:23: error: Function is missing a return type annotation
trie.py:32: error: Call to untyped function "TrieNode" in typed context
trie.py:49: error: Function is missing a return type annotation
trie.py:56: error: Function is missing a return type annotation
trie.py:78: error: Function is missing a return type annotation
trie.py:92: error: Function is missing a return type annotation
trie.py:94: error: Call to untyped function "TrieNode" in typed context
trie.py:115: error: Function is missing a return type annotation
trie.py:115: note: Use "-> None" if function does not return a value
trie.py:116: error: Call to untyped function "test_trie" in typed context
trie.py:119: error: Function is missing a return type annotation
trie.py:119: note: Use "-> None" if function does not return a value
trie.py:123: error: Call to untyped function "test_trie" in typed context
trie.py:127: error: Call to untyped function "main" in typed context
Found 14 errors in 1 file (checked 3 source files)
Annotate return type for all functions and type for "nodes"
7412ac3
to
a8ce436
Compare
Thanks for the review! 🙏🏽 That sgtm, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #4052
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.