Skip to content

[mypy] Fix type annotations for data_structures->linked_list directory files #4927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

[mypy] Fix type annotations for data_structures->linked_list directory files #4927

merged 1 commit into from
Oct 7, 2021

Conversation

ParthSatodiya
Copy link
Contributor 

$ python -m mypy -V
mypy 0.910
$ python -m mypy data_structures/linked_list/
Success: no issues found in 14 source files

Related Issue: #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 2, 2021
@poyea poyea self-assigned this Oct 4, 2021
poyea
poyea approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 7, 2021
@poyea poyea merged commit d324f91 into TheAlgorithms:master Oct 7, 2021
@ParthSatodiya
Copy link
Contributor Author

Thank you guys actually for maintaining this awesome repository. Keep it up guys 👍

This was referenced Oct 7, 2021
Closed
Closed
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@ParthSatodiya @shermanhui
Fix mypy errors for data_structures->linked_list directory files (The…
2b7d112 
…Algorithms#4927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParthSatodiya @poyea