Skip to content

PasswordGenerator.py #4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

PasswordGenerator.py #4873

wants to merge 1 commit into from

Conversation

6infected9
Copy link

Creates a Strong Password for fighting against bruteforce attack.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@6infected9
PasswordGenerator.py
6d95c4c 
Creates a Strong Password for fighting against bruteforce attack.
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 1, 2021
l3str4nge
l3str4nge reviewed Oct 1, 2021
View reviewed changes
PasswordGenerator.py
import random
import re

if __name__ == '__main__':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of algorithm is that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithm should be a function that returns a password (str) and does not print(). See CONTRIBUTING.md

cclauss
cclauss reviewed Oct 2, 2021
View reviewed changes
PasswordGenerator.py
@@ -0,0 +1,41 @@
# The main purpose of this is to get secure password to defend against Bruteforce attacks.
Copy link
Member

@cclauss cclauss Oct 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo requires that Python files are placed in an existing directory. See CONTRIBUTING.md.

@cclauss
Copy link
Member

cclauss commented Oct 2, 2021

Also, PasswordGenerator.py --> password_generator.py

@ghost ghost added the tests are failing Do not merge until tests pass label Oct 2, 2021
@poyea poyea mentioned this pull request Oct 4, 2021
Merged
14 tasks
@poyea
Copy link
Member

poyea commented Oct 4, 2021

Related PR #4950

@6infected9 6infected9 closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@l3str4nge l3str4nge l3str4nge left review comments

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@6infected9 @cclauss @poyea @l3str4nge