Skip to content

added carrier concentrations algorithm #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2021
Merged

added carrier concentrations algorithm #4791

merged 4 commits into from
Oct 11, 2021

Conversation

SidhaantThakker
Copy link
Contributor

@SidhaantThakker SidhaantThakker commented Sep 27, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Fixes #4792

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Sep 27, 2021
@SidhaantThakker SidhaantThakker mentioned this pull request Sep 27, 2021
Closed
@SidhaantThakker
Add more references
8792ff0 
Added more references to the carrier concentrations file
@SidhaantThakker
Copy link
Contributor Author

Added suggested commit 👍

poyea
poyea approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2021
@poyea poyea merged commit fadb976 into TheAlgorithms:master Oct 11, 2021
@SidhaantThakker
Copy link
Contributor Author

Cheers! 😄

shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@SidhaantThakker @poyea @shermanhui
Add carrier concentrations calculation algorithm (TheAlgorithms#4791)
d97a4f1 
* added carrier concentrations algorithm

* Add more references

Added more references to the carrier concentrations file

* Update electronics/carrier_concentration.py

Co-authored-by: John Law <[email protected]>

* Update electronics/carrier_concentration.py

Co-authored-by: John Law <[email protected]>

Co-authored-by: John Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Algorithm - Semiconductor Carrier Concentrations
2 participants
@SidhaantThakker @poyea