Skip to content

Fix data_structures/disjoint_set/disjoint_set.py #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix data_structures/disjoint_set/disjoint_set.py #4768

wants to merge 1 commit into from

Conversation

Alperencode
Copy link

@Alperencode Alperencode commented Sep 19, 2021

Fixes: #4764

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Sep 19, 2021
@Alperencode
Copy link
Author

Its actually not a hard change, i just change the if statement to work more properly and close the issue-#4764

@cclauss cclauss changed the title Fixes: #4764 Fix data_structures/disjoint_set/disjoint_set.py Sep 19, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Sep 19, 2021
@poyea poyea self-assigned this Sep 22, 2021
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test.

FAILED data_structures/disjoint_set/disjoint_set.py::data_structures.disjoint_set.disjoint_set.test_disjoint_set

I assume this change to be the correct one. Is there anything wrong in the current tests?

@Alperencode
Copy link
Author

I did not test it and actually i dont know how to test. I just fixed the code to close issue #4768. And that was not that complex i just changed the a few lines that shouldn't cause any problem.

@poyea
Copy link
Member

poyea commented Sep 23, 2021

@Alperencode It says something wrong with https://github.com/TheAlgorithms/Python/blob/master/data_structures/disjoint_set/disjoint_set.py#L57. Take an overall look and see what's wrong with the test? or you may change those 2 functions (+find_python_set) into one better function.

@Alperencode Alperencode closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with union in disjoint_set
2 participants