Skip to content

Improve Project Euler problem 009 solution 1 #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaximSmolskiy
Copy link
Member

Describe your change:

Improve Project Euler problem 009 solution 1 - the top 4 slowest solution on Travis CI logs (under slowest 10 durations: 14.61s call scripts/validate_solutions.py::test_project_euler[problem_009/sol1.py]):

  • Improve solution (locally 10+ times - from 10+ seconds to ~1 second)

  • Uncomment code that has been commented due to slow execution affecting Travis (now it should be quite fast execution and not affect Travis)

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Sep 10, 2021
@l3str4nge l3str4nge merged commit a7b9e28 into TheAlgorithms:master Sep 21, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 21, 2021
@l3str4nge
Copy link
Member

Awesome 🚀

@MaximSmolskiy MaximSmolskiy deleted the improve-project-euler-problem-009-solution-1 branch September 21, 2021 11:36
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Improve solution

* Uncomment code that has been commented due to slow execution affecting Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants