Skip to content

[mypy] fix type annotations for all Project Euler problems #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 11, 2021
Merged

[mypy] fix type annotations for all Project Euler problems #4747

merged 19 commits into from
Oct 11, 2021

Conversation

pikulet
Copy link
Contributor

@pikulet pikulet commented Sep 10, 2021

Describe your change:

Fixes #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

pikulet added 19 commits September 9, 2021 17:01
@pikulet
[mypy] fix type annotations for problem003/sol1 and problem003/sol3
21977f7
@pikulet
[mypy] fix type annotations for project euler problem007/sol2
ce8598f
@pikulet
[mypy] fix type annotations for project euler problem008/sol2
63100de
@pikulet
[mypy] fix type annotations for project euler problem009/sol1
0d6e0ee
@pikulet
[mypy] fix type annotations for project euler problem014/sol1
1f7c462
@pikulet
[mypy] fix type annotations for project euler problem 025/sol2
7037422
@pikulet
[mypy] fix type annotations for project euler problem026/sol1.py
8d09c05
@pikulet
[mypy] fix type annotations for project euler problem037/sol1
3f5af6b
@pikulet
[mypy] fix type annotations for project euler problem044/sol1
1542e16
@pikulet
[mypy] fix type annotations for project euler problem046/sol1
346d3ef
@pikulet
[mypy] fix type annotations for project euler problem051/sol1
5d8bbb3
@pikulet
[mypy] fix type annotations for project euler problem074/sol2
68341b9
@pikulet
[mypy] fix type annotations for project euler problem080/sol1
881b318
@pikulet
[mypy] fix type annotations for project euler problem099/sol1
731d73f
@pikulet
[mypy] fix type annotations for project euler problem101/sol1
bcc6636
@pikulet
[mypy] fix type annotations for project euler problem188/sol1
e77804f
@pikulet
[mypy] fix type annotations for project euler problem191/sol1
4dc5eaf
@pikulet
[mypy] fix type annotations for project euler problem207/sol1
4ed266a
@pikulet
[mypy] fix type annotations for project euler problem551/sol1
39eae36
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Sep 10, 2021
@pikulet
Copy link
Contributor Author

pikulet commented Sep 10, 2021

I've checked that they're all runnable, ran black & flake

poyea
poyea approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2021
@poyea poyea self-assigned this Oct 4, 2021
@poyea poyea changed the title [mypy] fix type annotations for all project euler problems, fixes #4052 [mypy] fix type annotations for all Project Euler problems Oct 4, 2021
@poyea
Copy link
Member

poyea commented Oct 4, 2021

#4052

@poyea poyea merged commit bcfca67 into TheAlgorithms:master Oct 11, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@pikulet @shermanhui
[mypy] fix type annotations for all Project Euler problems (TheAlgori…
0cab3a5 
…thms#4747)

* [mypy] fix type annotations for problem003/sol1 and problem003/sol3

* [mypy] fix type annotations for project euler problem007/sol2

* [mypy] fix type annotations for project euler problem008/sol2

* [mypy] fix type annotations for project euler problem009/sol1

* [mypy] fix type annotations for project euler problem014/sol1

* [mypy] fix type annotations for project euler problem 025/sol2

* [mypy] fix type annotations for project euler problem026/sol1.py

* [mypy] fix type annotations for project euler problem037/sol1

* [mypy] fix type annotations for project euler problem044/sol1

* [mypy] fix type annotations for project euler problem046/sol1

* [mypy] fix type annotations for project euler problem051/sol1

* [mypy] fix type annotations for project euler problem074/sol2

* [mypy] fix type annotations for project euler problem080/sol1

* [mypy] fix type annotations for project euler problem099/sol1

* [mypy] fix type annotations for project euler problem101/sol1

* [mypy] fix type annotations for project euler problem188/sol1

* [mypy] fix type annotations for project euler problem191/sol1

* [mypy] fix type annotations for project euler problem207/sol1

* [mypy] fix type annotations for project euler problem551/sol1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mypy] Need help to fix all mypy errors in the codebase
2 participants
@pikulet @poyea