Skip to content

Avoid mutable default arguments #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Avoid mutable default arguments #4691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphs/eulerian_path_and_circuit_for_undirected_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@


# using dfs for finding eulerian path traversal
def dfs(u, graph, visited_edge, path=[]):
path = path + [u]
def dfs(u, graph, visited_edge, path=None):
path = (path or []) + [u]
for v in graph[u]:
if visited_edge[u][v] is False:
visited_edge[u][v], visited_edge[v][u] = True, True
Expand Down
4 changes: 2 additions & 2 deletions graphs/frequent_pattern_graph_miner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,11 @@ def construct_graph(cluster, nodes):
return graph


def myDFS(graph, start, end, path=[]):
def myDFS(graph, start, end, path=None):
"""
find different DFS walk from given node to Header node
"""
path = path + [start]
path = (path or []) + [start]
if start == end:
paths.append(path)
for node in graph[start]:
Expand Down
6 changes: 3 additions & 3 deletions maths/radix2_fft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ class FFT:
A*B = 0*x^(-0+0j) + 1*x^(2+0j) + 2*x^(3+0j) + 3*x^(8+0j) + 4*x^(6+0j) + 5*x^(8+0j)
"""

def __init__(self, polyA=[0], polyB=[0]):
def __init__(self, polyA=None, polyB=None):
# Input as list
self.polyA = list(polyA)[:]
self.polyB = list(polyB)[:]
self.polyA = list(polyA or [0])[:]
self.polyB = list(polyB or [0])[:]

# Remove leading zero coefficients
while self.polyA[-1] == 0:
Expand Down