Skip to content

[mypy] Fix type annotations for integer_partition.py #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

[mypy] Fix type annotations for integer_partition.py #4689

merged 1 commit into from
Aug 30, 2021

Conversation

aswinmurali-io
Copy link
Contributor

@aswinmurali-io aswinmurali-io commented Aug 29, 2021 •
edited
Loading

Fix type annotations for integer_partition.py

Related issue #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 29, 2021
@aswinmurali-io aswinmurali-io changed the title [mypy] Fix type annotations for integer_partition.py #4052 [mypy] Fix type annotations for integer_partition.py Aug 29, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 30, 2021
@l3str4nge l3str4nge merged commit 3acca3d into TheAlgorithms:master Aug 30, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@aswinmurali-io @shermanhui
Fix type annotations for integer_partition.py TheAlgorithms#4052 (The…
5a65faf 
…Algorithms#4689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswinmurali-io @l3str4nge