Skip to content

[mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py, maths/{area.py, two_pointer.py, two_sum.py, ugly_numbers.py} sorts/cocktail_shaker_sort.py, insertion_sort.py #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

murari2401
Copy link

@murari2401 murari2401 commented Aug 25, 2021

Describe your change:

Fixes: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 25, 2021
@murari2401 murari2401 changed the title [mypy] Fix type annotations for backtracking/sudoku.py [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py Aug 26, 2021
@murari2401 murari2401 requested a review from Kush1101 as a code owner August 26, 2021 06:27
@murari2401 murari2401 changed the title [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py, maths/area.py Aug 26, 2021
@murari2401 murari2401 changed the title [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py, maths/area.py [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py, maths/{area.py, two_pointer.py, two_sum.py, ugly_numbers.py} Aug 26, 2021
@murari2401 murari2401 changed the title [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py, maths/{area.py, two_pointer.py, two_sum.py, ugly_numbers.py} [mypy] Fix type annotations for backtracking/sudoku.py, graphics/vector3_for_2d_rendering.py, maths/{area.py, two_pointer.py, two_sum.py, ugly_numbers.py} sorts/cocktail_shaker_sort.py, insertion_sort.py Aug 31, 2021
@cclauss cclauss closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mypy] Need help to fix all mypy errors in the codebase
2 participants