Skip to content

boruvka.py: A few simplifications and f-strings #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2021
Merged

boruvka.py: A few simplifications and f-strings #4660

merged 3 commits into from
Aug 24, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Aug 24, 2021 •
edited
Loading

Python f-strings simplify the code and should speed up execution.

I don’t know graphs… Are components and nodes the same things or different things?
If they are the same thing, then we should only use one name in the code and drop the other.
I looked it up.

@srkchowdary2000 Your review, please.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
boruvka.py: A few simplifications and f-strings
49dff07 
Python f-strings simplify the code and [should speed up execution](https://www.scivision.dev/python-f-string-speed). 

@srkchowdary2000 Your review, please.
@cclauss cclauss requested a review from l3str4nge August 24, 2021 01:13
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 24, 2021
@srkchowdary2000
Copy link
Contributor

Hi, they are different things components is a dictionary which represents smallest weighted root note for each node.
Wow, Amazing!!!
@cclauss

@l3str4nge l3str4nge merged commit 78a5d3a into master Aug 24, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 24, 2021
@cclauss cclauss deleted the cclauss-patch-3 branch August 24, 2021 13:29
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
boruvka.py: A few simplifications and f-strings (TheAlgorithms#4660)
924b91b 
* boruvka.py: A few simplifications and f-strings

Python f-strings simplify the code and [should speed up execution](https://www.scivision.dev/python-f-string-speed). 

@srkchowdary2000 Your review, please.

* updating DIRECTORY.md

* fixup! Streamline the test

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @srkchowdary2000 @l3str4nge