Skip to content

Renovate Readme.md #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 29, 2021
Merged

Renovate Readme.md #4620

merged 7 commits into from
Sep 29, 2021

Conversation

ss1208
Copy link
Contributor

@ss1208 ss1208 commented Aug 16, 2021

Conjunctive adverbs should be followed by a comma .

For more details, kindly refer:
https://www.aje.com/arc/editing-tip-commas-conjunctive-adverbs/

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

ss1208 added 2 commits August 16, 2021 20:48
@ss1208
Update README.md
02ec6fe 
Conjunctive adverbs should be followed by a comma .

For more details, kindly refer:
https://www.aje.com/arc/editing-tip-commas-conjunctive-adverbs/
@ss1208
Merge pull request #1 from ss1208/ss1208-patch-1
fd85a83 
Update README.md
@ghost ghost added awaiting reviews This PR is ready to be reviewed documentation This PR modified documentation files labels Aug 16, 2021
nivedha02
nivedha02 reviewed Aug 19, 2021
View reviewed changes
Copy link

@nivedha02 nivedha02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

nivedha02
nivedha02 suggested changes Aug 19, 2021
View reviewed changes
Copy link

@nivedha02 nivedha02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@stale
Copy link

stale bot commented Sep 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Sep 19, 2021
@ss1208
Copy link
Contributor Author

ss1208 commented Sep 20, 2021

Please review!

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Sep 20, 2021
poyea
poyea requested changes Sep 22, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma should be right after the word "Therefore".

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Sep 22, 2021
poyea
poyea reviewed Sep 22, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add Discord to our community channel section, as you're touching this file.

poyea
poyea reviewed Sep 22, 2021
View reviewed changes
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Sep 23, 2021
@poyea poyea changed the title Update Readme.md Renovate Readme.md Sep 23, 2021
poyea
poyea approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 29, 2021
dhruvmanila
dhruvmanila reviewed Sep 29, 2021
View reviewed changes
dhruvmanila
dhruvmanila approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single comment if it makes sense otherwise LGTM

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Sep 29, 2021
@dhruvmanila dhruvmanila merged commit d1e70cf into TheAlgorithms:master Sep 29, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 29, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@ss1208 @poyea
@dhruvmanila @shermanhui
docs: renovate README (TheAlgorithms#4620)
2344b9c 
Conjunctive adverbs should be followed by a comma.

For more details, kindly refer:
https://www.aje.com/arc/editing-tip-commas-conjunctive-adverbs/

Separate out the labels into two rows

Co-authored-by: John Law <[email protected]>
Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivedha02 nivedha02 nivedha02 requested changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

@cclauss cclauss Awaiting requested review from cclauss

@poyea poyea Awaiting requested review from poyea

@Erfaniaa Erfaniaa Awaiting requested review from Erfaniaa

@Eurus-Holmes Eurus-Holmes Awaiting requested review from Eurus-Holmes

@harshildarji harshildarji Awaiting requested review from harshildarji

Assignees
No one assigned
Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ss1208 @poyea @dhruvmanila @nivedha02