Skip to content

Created check_valid_ip_address.py #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2021
Merged

Created check_valid_ip_address.py #4602

merged 2 commits into from
Aug 8, 2021

Conversation

shubhamsg199
Copy link
Contributor

Added program: check_valid_ip_address for checking valid IP address

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@shubhamsg199 shubhamsg199 requested a review from Kush1101 as a code owner August 8, 2021 11:14
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Aug 8, 2021
l3str4nge
l3str4nge requested changes Aug 8, 2021
View reviewed changes
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typos -> see details in workflow loga

@ghost ghost added awaiting changes A maintainer has requested changes to this PR tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Aug 8, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 8, 2021
@shubhamsg199 shubhamsg199 requested a review from l3str4nge August 8, 2021 16:49
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 8, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 8, 2021
@l3str4nge l3str4nge merged commit 63ac09e into TheAlgorithms:master Aug 8, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@shubhamsg199 @shermanhui
Created check_valid_ip_address.py (TheAlgorithms#4602)
b1aa80b 
* Created check_valid_ip_address.py

* fixed typos error

Co-authored-by: root <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhamsg199 @l3str4nge