Skip to content

Refactor graph initializations at basic_graph.py #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2021
Merged

Refactor graph initializations at basic_graph.py #4601

merged 1 commit into from
Aug 11, 2021

Conversation

mhihasan
Copy link
Contributor

@mhihasan mhihasan commented Aug 8, 2021

Describe your change:

Refactor graph_initialization at basic_graph.py

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related issue #4052

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 8, 2021
@mhihasan mhihasan force-pushed the feature/refactor_basic_graph branch 3 times, most recently from 0a2d513 to 2a02055 Compare August 8, 2021 05:11
@mhihasan mhihasan force-pushed the feature/refactor_basic_graph branch from 2a02055 to 476f53b Compare August 8, 2021 05:12
@mhihasan mhihasan changed the title Refactor graph_initialization at basic_graph.py Refactor graph initializations at basic_graph.py Aug 8, 2021
l3str4nge
l3str4nge approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 11, 2021
@l3str4nge l3str4nge merged commit d668c17 into TheAlgorithms:master Aug 11, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@mhihasan @shermanhui
Refactor graph_initialization at basic_graph.py (TheAlgorithms#4601)
8b1a88c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhihasan @l3str4nge