Skip to content

Create exchange_sort.py #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2021
Merged

Create exchange_sort.py #4600

merged 4 commits into from
Aug 15, 2021

Conversation

bonnie-o7
Copy link
Contributor

@bonnie-o7 bonnie-o7 commented Aug 7, 2021 •
edited
Loading

Describe your change:

Added exchange sort as referenced from https://en.wikipedia.org/wiki/Sorting_algorithm#Exchange_sort

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@bonnie-o7
Create exchange_sort.py
6c317b9 
added exchange sort
@bonnie-o7 bonnie-o7 marked this pull request as ready for review August 7, 2021 22:04
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Aug 7, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Aug 9, 2021
l3str4nge
l3str4nge requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also take a look at build fail details.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 9, 2021
@bonnie-o7
Fixed formatting error and added new length variable
37a713a 
added empty line at end of exchange_sort.py and turned len(numbers) into a variable
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 11, 2021
@l3str4nge
Copy link
Member

Tests are still failing @bonbon99

@bonnie-o7
Copy link
Contributor Author

Thank you for reviewing @l3str4nge !

@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 15, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 15, 2021
@l3str4nge l3str4nge merged commit 032999f into TheAlgorithms:master Aug 15, 2021
@bonnie-o7 bonnie-o7 deleted the exchange_sort branch August 16, 2021 01:36
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@bonnie-o7 @shermanhui
Create exchange_sort.py (TheAlgorithms#4600)
19a699c 
* Create exchange_sort.py

added exchange sort

* Fixed doctest in exchange_sort.py

* Fixed formatting error and added new length variable

added empty line at end of exchange_sort.py and turned len(numbers) into a variable

* Fixed formatting errors with black

added empty line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonnie-o7 @l3str4nge