Skip to content

add alternative_string_arrange method #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2021
Merged

add alternative_string_arrange method #4595

merged 4 commits into from
Aug 6, 2021

Conversation

suryapratapsinghsuryavanshi
Copy link
Contributor

Describe your change:

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 6, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 6, 2021
Sin-Sumit
Sin-Sumit approved these changes Aug 6, 2021
View reviewed changes
Copy link

@Sin-Sumit Sin-Sumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternative_string_arramgements.py is reviewed by me and it is good.

l3str4nge
l3str4nge requested changes Aug 6, 2021
View reviewed changes
Copy link
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change variable name and I will approve it because it looks good :)

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Aug 6, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Aug 6, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 6, 2021
@l3str4nge l3str4nge merged commit f432bc7 into TheAlgorithms:master Aug 6, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@suryapratapsinghsuryavanshi @shermanhui
add alternative_string_arrange method (TheAlgorithms#4595)
8d6abb8 
* add alternative_string_arrange method

* fix issue

* fix one more issue

* changed the variable name li to output_list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@Sin-Sumit Sin-Sumit Sin-Sumit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suryapratapsinghsuryavanshi @l3str4nge @Sin-Sumit