Skip to content

Fix mypy errors at bidirectional_bfs #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix mypy errors at bidirectional_bfs #4531

merged 1 commit into from
Jul 12, 2021

Conversation

mhihasan
Copy link
Contributor

@mhihasan mhihasan commented Jul 8, 2021

Describe your change:

  • Fix mypy errors at bidirectional_bfs

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Related issue #4052

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 8, 2021
@mhihasan mhihasan force-pushed the fix/fix_mypy_error_at_bidirectional_bfs branch from b0a6d68 to 62411ed Compare July 8, 2021 07:23
@l3str4nge l3str4nge merged commit 307ffd8 into TheAlgorithms:master Jul 12, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 12, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@mhihasan @shermanhui
Fix mypy errors at bidirectional_bfs (TheAlgorithms#4531)
af6ed88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhihasan @l3str4nge