Skip to content

feat: Add Discord badge in README.md #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2021
Merged

feat: Add Discord badge in README.md #4357

merged 2 commits into from
Apr 26, 2021

Conversation

Panquesito7
Copy link
Member

Describe your change:

  • Add Discord badge in README.md.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Panquesito7 Panquesito7 requested a review from cclauss April 25, 2021 20:41
@ghost ghost added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Apr 25, 2021
@ghost ghost added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Apr 26, 2021
@dhruvmanila
Copy link
Member

Hmm, weird. No idea why the checks are failing. Although, it is unrelated to the changes made in this PR.

@dhruvmanila dhruvmanila merged commit 2ce6be0 into master Apr 26, 2021
@Panquesito7 Panquesito7 deleted the add_discord_badge branch April 26, 2021 04:31
Panquesito7 added a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* feat: Add Discord badge in `README.md`

* Update README.md

Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* feat: Add Discord badge in `README.md`

* Update README.md

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This PR modified documentation files tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants