Skip to content

Rename lstm_prediction.py_tf to lstm_prediction.py #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tinubaby
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Apr 18, 2021
@ghost ghost mentioned this pull request Apr 18, 2021
13 tasks
@dhruvmanila
Copy link
Member

dhruvmanila commented Apr 27, 2021

Hey, @tinubaby you need to remove the condition from requirements.txt for tensorflow library so that it will be installed in our tests.

@dhruvmanila
Copy link
Member

Also, please collect all your renaming pull requests into one PR. There's no point in keeping them separate, they are minor updates :)

@cclauss
Copy link
Member

cclauss commented Apr 28, 2021

I believe that this will fail our tests because of #3946

@dhruvmanila
Copy link
Member

Closing in favor of #4331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants