Mypy fix rotation.py #4319
Merged
Mypy fix rotation.py #4319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobytewise
requested review from
cclauss,
dhruvmanila and
l3str4nge
as code owners
This reverts commit c2d04ae.
|
I reverted the changes to build.yml since this file being changed by another pull request, leading to a merge conflict. |
cclauss
reviewed
Apr 6, 2021
| @@ -1,11 +1,12 @@ | |||
| import cv2 | |||
| import numpy as np | |||
| from matplotlib import pyplot as plt | |||
| import os.path | |||
There was a problem hiding this comment.
Please use https://docs.python.org/3/library/pathlib.html instead of os.path for improved readability.
There was a problem hiding this comment.
from pathlib import Path
Path(__file__).resolve().parent / "image_data" / "lena.jpg"
|
Please rebase onto the latest master and remove the directory from $ git remote add upstream https://github.com/TheAlgorithms/Python
$ git fetch upstream master
$ git merge upstream/master
$ git rebase master mypy-fix-rotation.py |
* feat: Add mypy config file * refactor: Remove mypy options from build workflow * Remove linear_algebra Co-authored-by: Christian Clauss <[email protected]>
ghost
added
tests are failing
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* fix type-hints arguments * fix matrices & image-path * Update build.yml * Revert "Update build.yml" This reverts commit c2d04ae. * use pathlib * feat: Add mypy configuration file (TheAlgorithms#4315) * feat: Add mypy config file * refactor: Remove mypy options from build workflow * Remove linear_algebra Co-authored-by: Christian Clauss <[email protected]> * rebase & update mypy.ini * fix pre-commit errors Co-authored-by: Dhruv Manilawala <[email protected]> Co-authored-by: Christian Clauss <[email protected]>
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* fix type-hints arguments * fix matrices & image-path * Update build.yml * Revert "Update build.yml" This reverts commit c2d04ae. * use pathlib * feat: Add mypy configuration file (TheAlgorithms#4315) * feat: Add mypy config file * refactor: Remove mypy options from build workflow * Remove linear_algebra Co-authored-by: Christian Clauss <[email protected]> * rebase & update mypy.ini * fix pre-commit errors Co-authored-by: Dhruv Manilawala <[email protected]> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Related Issue: #4052
Checklist:
Fixes: #{$ISSUE_NO}.