Skip to content

[mypy] fix compression folder #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 22, 2021
Merged

[mypy] fix compression folder #4290

merged 7 commits into from
Mar 22, 2021

Conversation

algobytewise
Copy link
Contributor

Describe your change:

Related Issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 22, 2021
@cclauss
Copy link
Member

cclauss commented Mar 22, 2021

@iko1133 Can you please review the change to compression/lempel_ziv.py ?

@algobytewise
Copy link
Contributor Author

I fixed the doctest in "2_hidden_layers_neural_network.py". I think the problem was that it has random initial weights, which is why the doctest sometimes failed.

@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 22, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 22, 2021
@cclauss cclauss merged commit a8db5d4 into TheAlgorithms:master Mar 22, 2021
@algobytewise algobytewise deleted the mypy-fix-compression-folder branch March 23, 2021 15:54
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@algobytewise @peRFectBeliever
[mypy] fix compression folder (TheAlgorithms#4290)
911694c 
* Update lempel_ziv.py

* Update build.yml

* updating DIRECTORY.md

* fix doctest in 2_hidden_layers_neural_network.py

* one more doctest

* simplified tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@algobytewise
[mypy] fix compression folder (TheAlgorithms#4290)
196dd45 
* Update lempel_ziv.py

* Update build.yml

* updating DIRECTORY.md

* fix doctest in 2_hidden_layers_neural_network.py

* one more doctest

* simplified tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@algobytewise @shermanhui
[mypy] fix compression folder (TheAlgorithms#4290)
1291faf 
* Update lempel_ziv.py

* Update build.yml

* updating DIRECTORY.md

* fix doctest in 2_hidden_layers_neural_network.py

* one more doctest

* simplified tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@iko1133 iko1133 iko1133 approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algobytewise @cclauss @iko1133