Skip to content

Moved "other/anagrams.py" to the string folder #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2021
Merged

Moved "other/anagrams.py" to the string folder #4289

merged 2 commits into from
Mar 22, 2021

Conversation

algobytewise
Copy link
Contributor

@algobytewise algobytewise commented Mar 22, 2021 •
edited
Loading

Describe your change:

anagrams.py depends on the file "words", which has been moved as well and renamed to "words.txt"
Fixes #4284

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 22, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Mar 22, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 22, 2021
@cclauss cclauss merged commit 0ee8f79 into TheAlgorithms:master Mar 22, 2021
princemadhia
princemadhia approved these changes Mar 22, 2021
View reviewed changes
.pre-commit-config.yaml
@@ -43,12 +43,12 @@ repos:
- id: codespell
args:
- --ignore-words-list=ans,crate,fo,followings,hist,iff,mater,secant,som,tim
- --skip="./.*,./strings/dictionary.txt,./other/words,./project_euler/problem_022/p022_names.txt"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is worong string try import fish.&&^

@algobytewise algobytewise deleted the fix-extension-and-move branch March 23, 2021 15:54
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@algobytewise @peRFectBeliever
Moved "other/anagrams.py" to the string folder (TheAlgorithms#4289)
f1030ea 
* move&rename, changed code accordingly

* adjusted codespell ignore-list
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@algobytewise
Moved "other/anagrams.py" to the string folder (TheAlgorithms#4289)
471b959 
* move&rename, changed code accordingly

* adjusted codespell ignore-list
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@algobytewise @shermanhui
Moved "other/anagrams.py" to the string folder (TheAlgorithms#4289)
99e8b60 
* move&rename, changed code accordingly

* adjusted codespell ignore-list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@princemadhia princemadhia princemadhia approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to move the file "other/words"
3 participants
@algobytewise @cclauss @princemadhia