Skip to content

Include mypy instructions in CONTRIBUTING.md #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 19, 2021
Merged

Include mypy instructions in CONTRIBUTING.md #4271

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec738b0
Merge pull request #1 from TheAlgorithms/master
algobytewise Feb 23, 2021
5ee6c48
Merge pull request #2 from TheAlgorithms/master
algobytewise Feb 24, 2021
1367811
Merge pull request #3 from TheAlgorithms/master
algobytewise Feb 28, 2021
681d30c
reupload
algobytewise Mar 1, 2021
8467a83
Merge pull request #4 from TheAlgorithms/master
algobytewise Mar 14, 2021
7dcd57b
Merge pull request #5 from TheAlgorithms/master
algobytewise Mar 19, 2021
3813480
Include mypy instructions
algobytewise Mar 19, 2021
1910537
delete file
algobytewise Mar 19, 2021
6e62d6c
fixed trailing whitespaces
algobytewise Mar 19, 2021
cf7b994
options before file path
cclauss Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ We want your work to be readable by others; therefore, we encourage you to note
return a + b
```

Instructions on how to install mypy can be found [here](https://github.com/python/mypy). Please use the command `mypy . --ignore-missing-imports` to test all files or `mypy path_to_file.py --ignore-missing-imports` to test one specific file.

- [__List comprehensions and generators__](https://docs.python.org/3/tutorial/datastructures.html#list-comprehensions) are preferred over the use of `lambda`, `map`, `filter`, `reduce` but the important thing is to demonstrate the power of Python in code that is easy to read and maintain.

- Avoid importing external libraries for basic algorithms. Only use those libraries for complicated algorithms.
Expand Down