Skip to content

GitHub Actions: fast-fail on black formatting issues #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2021
Merged

GitHub Actions: fast-fail on black formatting issues #4268

merged 2 commits into from
Mar 20, 2021

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 15, 2021 •
edited
Loading

Give fast feedback to contributors https://github.com/psf/black#github-actions

Describe your change:

  • Improve out tests
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner March 15, 2021 10:58
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 15, 2021
@cclauss cclauss requested a review from l3str4nge March 19, 2021 10:30
dhruvmanila
dhruvmanila approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! Sorry for the late response.

@dhruvmanila dhruvmanila merged commit b8a19cc into master Mar 20, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 20, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@cclauss @peRFectBeliever
GitHub Actions: fast-fail on black formatting issues (TheAlgorithms#4268
22b196b 
)

* GitHub Actions: fast-fail on black formatting issues

Give fast feedback to contributors https://github.com/psf/black#github-actions

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss
GitHub Actions: fast-fail on black formatting issues (TheAlgorithms#4268
df893b6 
)

* GitHub Actions: fast-fail on black formatting issues

Give fast feedback to contributors https://github.com/psf/black#github-actions

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
GitHub Actions: fast-fail on black formatting issues (TheAlgorithms#4268
3f59efe 
)

* GitHub Actions: fast-fail on black formatting issues

Give fast feedback to contributors https://github.com/psf/black#github-actions

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@dhruvmanila dhruvmanila deleted the fast-fail-on-black-formatting-issues branch October 1, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees

@l3str4nge l3str4nge

@dhruvmanila dhruvmanila

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @dhruvmanila @l3str4nge