Add algorithm for N-body simulation #4245
Conversation
sync fork
update fork
update fork
ghost
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| body.update_position(delta_time * self.time_factor) | ||
|
|
||
|
|
||
| def plot( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function plot
other/n_body_simulation.py
Outdated
| ) | ||
|
|
||
| # Function called once at the start of the animation | ||
| def init() -> list[patches.Circle]: # type: ignore |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function init
other/n_body_simulation.py
Outdated
| return patches | ||
|
|
||
| # Function called at each step of the animation | ||
| def animate(i: int) -> list[patches.Circle]: # type: ignore |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function animate
Please provide descriptive name for the parameter: i
ghost
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| body.update_position(delta_time * self.time_factor) | ||
|
|
||
|
|
||
| def plot( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function plot
other/n_body_simulation.py
Outdated
| ) | ||
|
|
||
| # Function called once at the start of the animation | ||
| def init() -> list[patches.Circle]: # type: ignore |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function init
other/n_body_simulation.py
Outdated
| return patches | ||
|
|
||
| # Function called at each step of the animation | ||
| def animate(i: int) -> list[patches.Circle]: # type: ignore |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function animate
Please provide descriptive name for the parameter: i
ghost
mentioned this pull request
|
Could someone have a look at the algorithm? I can answer questions here if some of the steps are unclear. |
ghost
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| body.update_position(delta_time * self.time_factor) | ||
|
|
||
|
|
||
| def plot( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function plot
| ) | ||
|
|
||
| # Function called once at the start of the animation | ||
| def init() -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function init
| return patches | ||
|
|
||
| # Function called at each step of the animation | ||
| def update(frame: int) -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function update
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| body.update_position(delta_time * self.time_factor) | ||
|
|
||
|
|
||
| def plot( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function plot
| ) | ||
|
|
||
| # Function called once at the start of the animation | ||
| def init() -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function init
| return patches | ||
|
|
||
| # Function called at each step of the animation | ||
| def update(frame: int) -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function update
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| body.update_position(delta_time * self.time_factor) | ||
|
|
||
|
|
||
| def plot( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function plot
| ) | ||
|
|
||
| # Function called once at the start of the animation | ||
| def init() -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function init
| return patches | ||
|
|
||
| # Function called at each step of the animation | ||
| def update(frame: int) -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function update
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| body.update_position(delta_time * self.time_factor) | ||
|
|
||
|
|
||
| def plot( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function plot
| ) | ||
|
|
||
| # Function called once at the start of the animation | ||
| def init() -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function init
| return patches | ||
|
|
||
| # Function called at each step of the animation | ||
| def update(frame: int) -> list[patches.Circle]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/n_body_simulation.py, please provide doctest for the function update
|
I have opened a new pull request to replace this one: #4298 |
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.