Skip to content

[mypy] Added/fixed type annotations for "crawl_google_results.py" & "crawl_google_scholar_citation.py" #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

algobytewise
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 24, 2021
@cclauss
Copy link
Member

cclauss commented Feb 24, 2021

@algobytewise
Copy link
Contributor Author

The errors don't arise in the original files when running mypy with the parameter "--ignore-missing-imports". Should files with this type of error be fixed nonetheless or can they be ignored?

@algobytewise
Copy link
Contributor Author

The advantage would be that we have to fix less files. But I'm not sure whether it's in our interest to ignore all missing import errors instead of selecting which one's to ignore.

@ghost ghost mentioned this pull request Mar 14, 2021
14 tasks
@algobytewise
Copy link
Contributor Author

Could someone have a look at this contribution?

@cclauss
Copy link
Member

cclauss commented Mar 19, 2021

Instead, please run mypy --ignore-missing-imports and find and fix mypy issues in our code (not the issues in our imports) so that we can uncomment these tests. https://github.com/TheAlgorithms/Python/blob/master/.pre-commit-config.yaml#L33

@cclauss cclauss closed this Mar 19, 2021
@algobytewise algobytewise deleted the mypy-fix-web_programming branch March 21, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants