Skip to content

Changes occurences of str.format to f-strings #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 23, 2021
Merged

Changes occurences of str.format to f-strings #4118

merged 15 commits into from
Feb 23, 2021

Conversation

CarsonHam
Copy link
Contributor

@CarsonHam CarsonHam commented Jan 13, 2021 •
edited
Loading

Describe your change:

fixes: #4117

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@CarsonHam CarsonHam requested a review from Kush1101 as a code owner January 13, 2021 04:57
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jan 13, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jan 20, 2021
@poyea poyea self-assigned this Jan 20, 2021
@poyea
Copy link
Member

poyea commented Jan 20, 2021

Beautiful f-strings. Thanks for your pull request and effort!🤩

dhruvmanila
dhruvmanila approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@dhruvmanila dhruvmanila merged commit 61f3119 into TheAlgorithms:master Feb 23, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@CarsonHam @peRFectBeliever
Change occurrences of str.format to f-strings (TheAlgorithms#4118)
3fa9c9f 
* f-string update rsa_cipher.py

* f-string update rsa_key_generator.py

* f-string update burrows_wheeler.py

* f-string update non_recursive_segment_tree.py

* f-string update red_black_tree.py

* f-string update deque_doubly.py

* f-string update climbing_stairs.py

* f-string update iterating_through_submasks.py

* f-string update knn_sklearn.py

* f-string update 3n_plus_1.py

* f-string update quadratic_equations_complex_numbers.py

* f-string update nth_fibonacci_using_matrix_exponentiation.py

* f-string update sherman_morrison.py

* f-string update levenshtein_distance.py

* fix lines that were too long
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@CarsonHam
Change occurrences of str.format to f-strings (TheAlgorithms#4118)
c236509 
* f-string update rsa_cipher.py

* f-string update rsa_key_generator.py

* f-string update burrows_wheeler.py

* f-string update non_recursive_segment_tree.py

* f-string update red_black_tree.py

* f-string update deque_doubly.py

* f-string update climbing_stairs.py

* f-string update iterating_through_submasks.py

* f-string update knn_sklearn.py

* f-string update 3n_plus_1.py

* f-string update quadratic_equations_complex_numbers.py

* f-string update nth_fibonacci_using_matrix_exponentiation.py

* f-string update sherman_morrison.py

* f-string update levenshtein_distance.py

* fix lines that were too long
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@CarsonHam @shermanhui
Change occurrences of str.format to f-strings (TheAlgorithms#4118)
c95337f 
* f-string update rsa_cipher.py

* f-string update rsa_key_generator.py

* f-string update burrows_wheeler.py

* f-string update non_recursive_segment_tree.py

* f-string update red_black_tree.py

* f-string update deque_doubly.py

* f-string update climbing_stairs.py

* f-string update iterating_through_submasks.py

* f-string update knn_sklearn.py

* f-string update 3n_plus_1.py

* f-string update quadratic_equations_complex_numbers.py

* f-string update nth_fibonacci_using_matrix_exponentiation.py

* f-string update sherman_morrison.py

* f-string update levenshtein_distance.py

* fix lines that were too long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@amaank404 amaank404 amaank404 approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: use f-strings instead of str format
4 participants
@CarsonHam @poyea @dhruvmanila @amaank404