Skip to content

Graph list patch #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 12, 2021
Merged

Graph list patch #4113

merged 13 commits into from
Jan 12, 2021

Conversation

chidi-godwin
Copy link
Contributor

Describe your change:

  • New implementation for Adjacency List type Graphs.
  • Works for both directed and undirected graphs.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jan 8, 2021
@cclauss
Copy link
Member

cclauss commented Jan 9, 2021

Please look at the failing test... psf/black just wants you to add one blank line.

@chidi-godwin
Copy link
Contributor Author

Please look at the failing test... psf/black just wants you to add one blank line.

I have made the edit, but I'm currently facing new issues.
pre-commit won't commit changes cause the validate filename check failed, this is because it's checking the virtual environment folder. I've tried to exclude this folder by adding an exclusion but it still didn't work
- repo: local hooks: - id: validate-filenames name: Validate filenames entry: ./scripts/validate_filenames.py language: script pass_filenames: false exclude: ^env.* # my edit

@ghost ghost removed the tests are failing Do not merge until tests pass label Jan 9, 2021
cclauss
cclauss requested changes Jan 12, 2021
View reviewed changes
graphs/graph_list.py Outdated
# with destination vertex as key, which has no adjacent vertex
else:
self.adj_list[source_vertex] = [destination_vertex]
self.adj_list[destination_vertex] = []

def print_list(self) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this __str__() instead and then print(graph) and print(repr(graph)).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need doctests for both.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jan 12, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR labels Jan 12, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Jan 12, 2021
cclauss
cclauss reviewed Jan 12, 2021
View reviewed changes
graphs/graph_list.py Outdated
def print_list(self) -> None:
return self

def __str__(self) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... If __str__() and __repr__() are going to return the same values then we can delete __str__() but leave the tests unmodulated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ghost ghost added the tests are failing Do not merge until tests pass label Jan 12, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Jan 12, 2021
@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Jan 12, 2021
cclauss
cclauss approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably too many comments but let's land it.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jan 12, 2021
@cclauss cclauss merged commit 03d3435 into TheAlgorithms:master Jan 12, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@chidi-godwin @cclauss @peRFectBeliever
Graph list patch (TheAlgorithms#4113)
744cf0d 
* new implementation for adjacency list graph

* add example code for undirected graph

* reduce length to 88 columns max to fix build errors7

* fix pre commit issues

* replace print_list method with __str__

* return object in add_edge method to enable fluent syntax

* improve class docstring and include doctests

* add end of file line

* fix pre-commit issues

* remove __str__ method

* trigger build

* Update graph_list.py

* Update graph_list.py

Co-authored-by: gnc <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@chidi-godwin @cclauss
Graph list patch (TheAlgorithms#4113)
9b3fa50 
* new implementation for adjacency list graph

* add example code for undirected graph

* reduce length to 88 columns max to fix build errors7

* fix pre commit issues

* replace print_list method with __str__

* return object in add_edge method to enable fluent syntax

* improve class docstring and include doctests

* add end of file line

* fix pre-commit issues

* remove __str__ method

* trigger build

* Update graph_list.py

* Update graph_list.py

Co-authored-by: gnc <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@chidi-godwin @cclauss @shermanhui
Graph list patch (TheAlgorithms#4113)
942acdd 
* new implementation for adjacency list graph

* add example code for undirected graph

* reduce length to 88 columns max to fix build errors7

* fix pre commit issues

* replace print_list method with __str__

* return object in add_edge method to enable fluent syntax

* improve class docstring and include doctests

* add end of file line

* fix pre-commit issues

* remove __str__ method

* trigger build

* Update graph_list.py

* Update graph_list.py

Co-authored-by: gnc <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@amaank404 amaank404 amaank404 approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chidi-godwin @cclauss @amaank404