Skip to content

[mypy] Add/fix type annotations for scheduling algorithms #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2020
Merged

[mypy] Add/fix type annotations for scheduling algorithms #4074

merged 4 commits into from
Dec 28, 2020
+18 −19

Conversation

shan7030
Copy link
Contributor 

$ mypy --strict scheduling/ --ignore-missing-imports
Success: no issues found in 4 source files

Related Issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Dec 27, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Dec 27, 2020
dhruvmanila
dhruvmanila approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Thank you for doing this! 👍

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 28, 2020
@dhruvmanila dhruvmanila merged commit 00e279e into TheAlgorithms:master Dec 28, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@shan7030 @stokhos
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
feecb58 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@shan7030 @peRFectBeliever
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
9529d7f 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@shan7030
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
d16a180 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@shan7030 @shermanhui
[mypy] Add/fix type annotations for scheduling algorithms (TheAlgorit…
cbb2d56 
…hms#4074)

* Fix mypy errors for scheduling/first_come_first_served
* Fix mypy errors for scheduling/round_robin.py
* Fix mypy errors for scheduling/shortest_job_first.py
* Fix isort errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shan7030 @dhruvmanila