Skip to content

updated area.py #4065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 28, 2020
Merged

updated area.py #4065

merged 7 commits into from
Dec 28, 2020

Conversation

SiddhantJain15
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@SiddhantJain15
Update area.py
45da824 
Modified area of triangle function. Added a new algorithm to calculate area when 3 sides are known
@SiddhantJain15
Add files via upload
9bd29af
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Dec 26, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Dec 26, 2020
dhruvmanila
dhruvmanila requested changes Dec 27, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please don't remove the newlines in the docstring of other functions. They are meant to separate out the function description and the doctest.

@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Dec 27, 2020
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Dec 27, 2020
dhruvmanila
dhruvmanila approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 28, 2020
@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Dec 28, 2020
@dhruvmanila dhruvmanila merged commit dd4b265 into TheAlgorithms:master Dec 28, 2020
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 28, 2020
@SiddhantJain15 SiddhantJain15 deleted the patch-2 branch December 28, 2020 08:22
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@SiddhantJain15 @dhruvmanila @stokhos
Add function to calculate area of triangle using Heron's formula (The…
ff134c5 
…Algorithms#4065)

* Update area.py

Modified area of triangle function. Added a new algorithm to calculate area when 3 sides are known

* Add files via upload

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Remove unnecessary whitespace

Co-authored-by: Dhruv Manilawala <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@SiddhantJain15 @dhruvmanila @peRFectBeliever
Add function to calculate area of triangle using Heron's formula (The…
bee23dd 
…Algorithms#4065)

* Update area.py

Modified area of triangle function. Added a new algorithm to calculate area when 3 sides are known

* Add files via upload

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Remove unnecessary whitespace

Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@SiddhantJain15 @dhruvmanila
Add function to calculate area of triangle using Heron's formula (The…
ecfae11 
…Algorithms#4065)

* Update area.py

Modified area of triangle function. Added a new algorithm to calculate area when 3 sides are known

* Add files via upload

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Remove unnecessary whitespace

Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@SiddhantJain15 @dhruvmanila @shermanhui
Add function to calculate area of triangle using Heron's formula (The…
48af9e9 
…Algorithms#4065)

* Update area.py

Modified area of triangle function. Added a new algorithm to calculate area when 3 sides are known

* Add files via upload

* Update area.py

* Update area.py

* Update area.py

* Update area.py

* Remove unnecessary whitespace

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiddhantJain15 @dhruvmanila