Adding 2-hidden layer neural network with back propagation using sigmoid activation function #4037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
awaiting reviews
ghost
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require type hints
ghost
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
added
awaiting reviews
|
@dhruvmanila Your review, please? |
|
@algorithms-keeper review |
ghost
reviewed
Dec 22, 2020
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
@raman77768 Please resolve the conversation for which the changes have been implemented, that will make the review process easier. |
|
@dhruvmanila Resolved the conversations where changes were made. |
cclauss
reviewed
Dec 25, 2020
cclauss
approved these changes
Dec 25, 2020
dhruvmanila
requested changes
Dec 25, 2020
There was a problem hiding this comment.
mypy still complains:
$ mypy 2_hidden_layers_neural_network.py
2_hidden_layers_neural_network.py:95: error: No return value expected
2_hidden_layers_neural_network.py:114: error: "float" has no attribute "T"
2_hidden_layers_neural_network.py:120: error: "float" has no attribute "T"
2_hidden_layers_neural_network.py:179: error: "feedforward" of "TwoHiddenLayerNeuralNetwork" does not return a value
2_hidden_layers_neural_network.py:182: error: "feedforward" of "TwoHiddenLayerNeuralNetwork" does not return a value
dhruvmanila
removed
the
require proper documentation
ghost
added
awaiting reviews
|
@raman77768 Please run |
|
@dhruvmanila |
|
That is because you provided the incorrect type hint for the parameter and for the function Another thing to note is that |
dhruvmanila
approved these changes
Dec 26, 2020
|
Yeah!! 64 comments! Is that a record? |
|
Lol, a record for what? Also, some of the reviews were made by the bot ;-) |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
… activation function (TheAlgorithms#4037) * added neural network with 2 hidden layers * Revert "added neural network with 2 hidden layers" This reverts commit fa4e2ac. * added neural network with 2 hidden layers * passing pre-commit requirements * doctest completed * added return hints * added example * example added * completed doctest's * changes made as per the review * changes made * changes after review * changes * spacing * changed return type * changed dtype
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
… activation function (TheAlgorithms#4037) * added neural network with 2 hidden layers * Revert "added neural network with 2 hidden layers" This reverts commit fa4e2ac. * added neural network with 2 hidden layers * passing pre-commit requirements * doctest completed * added return hints * added example * example added * completed doctest's * changes made as per the review * changes made * changes after review * changes * spacing * changed return type * changed dtype
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
… activation function (TheAlgorithms#4037) * added neural network with 2 hidden layers * Revert "added neural network with 2 hidden layers" This reverts commit fa4e2ac. * added neural network with 2 hidden layers * passing pre-commit requirements * doctest completed * added return hints * added example * example added * completed doctest's * changes made as per the review * changes made * changes after review * changes * spacing * changed return type * changed dtype
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
… activation function (TheAlgorithms#4037) * added neural network with 2 hidden layers * Revert "added neural network with 2 hidden layers" This reverts commit fa4e2ac. * added neural network with 2 hidden layers * passing pre-commit requirements * doctest completed * added return hints * added example * example added * completed doctest's * changes made as per the review * changes made * changes after review * changes * spacing * changed return type * changed dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.