-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Update bitonic_sort with type hints, doctest, snake_case names #4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Report@Joe-Sin7h Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request. There seems to be missing requirements in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report. What are node paths? 🔽
Following functions require tests [
|
There were no doctests initially in bitonic_sort.py. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, can you please fix all the requirements mentioned in the comment made by the bot?
doctest
- Descriptive parameter names
- Using
snake_case
- Providing type hints
If not, then please fix the pre-commit
error, and then we're good to go!
…gorithms#4016) * Updated input * Fix pre-commit error * Add type hints, doctests, black, snake_case Co-authored-by: Dhruv Manilawala <[email protected]>
…gorithms#4016) * Updated input * Fix pre-commit error * Add type hints, doctests, black, snake_case Co-authored-by: Dhruv Manilawala <[email protected]>
…gorithms#4016) * Updated input * Fix pre-commit error * Add type hints, doctests, black, snake_case Co-authored-by: Dhruv Manilawala <[email protected]>
…gorithms#4016) * Updated input * Fix pre-commit error * Add type hints, doctests, black, snake_case Co-authored-by: Dhruv Manilawala <[email protected]>
Describe your change:
Fixes : #4015
Checklist:
Fixes: #{$ISSUE_NO}
.