-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Fixes: #3944 authentication error #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #3944 authentication error #3949
Conversation
Pull Request Report@lawric1 Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request. I have detected errors in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report. What are node paths?The report contain headings and a checklist where the items are paths to the class/function/parameter where the error is present. Node paths are double colon
Following functions require tests [
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read the GitHub REST API documentation and apply the requested changes.
Combine the module-level docstring into one and that should come first, before any of the imports.
…tHub REST API standards
Thanks for all the feedback, this is my first time contributing and i'm learning a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this and I hope you learned a lot. I added a test for this function using monkeypatch
from pytest
. If you have any doubt regarding the tests, please feel free to ask as it is difficult to write tests for web programming, especially for beginners.
…heAlgorithms#3949) * fixes TheAlgorithms#3944 authentication error * Fixes: TheAlgorithms#3944 authentication error * Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards * run black formatter * Add USER_TOKEN constant and checks if empty, removes deprecated docstring * Add descriptive dict type hint, change headers format to f-string * Add Accept header * Fix pre-commit error * Fix pre-commit error * Add test for fetch_github_info * Remove test function from main file * Create test_fetch_github_info.py * Update test_fetch_github_info.py * Update test_fetch_github_info.py * No need to cover __name__ == __main__ block Co-authored-by: Dhruv Manilawala <[email protected]>
…heAlgorithms#3949) * fixes TheAlgorithms#3944 authentication error * Fixes: TheAlgorithms#3944 authentication error * Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards * run black formatter * Add USER_TOKEN constant and checks if empty, removes deprecated docstring * Add descriptive dict type hint, change headers format to f-string * Add Accept header * Fix pre-commit error * Fix pre-commit error * Add test for fetch_github_info * Remove test function from main file * Create test_fetch_github_info.py * Update test_fetch_github_info.py * Update test_fetch_github_info.py * No need to cover __name__ == __main__ block Co-authored-by: Dhruv Manilawala <[email protected]>
…heAlgorithms#3949) * fixes TheAlgorithms#3944 authentication error * Fixes: TheAlgorithms#3944 authentication error * Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards * run black formatter * Add USER_TOKEN constant and checks if empty, removes deprecated docstring * Add descriptive dict type hint, change headers format to f-string * Add Accept header * Fix pre-commit error * Fix pre-commit error * Add test for fetch_github_info * Remove test function from main file * Create test_fetch_github_info.py * Update test_fetch_github_info.py * Update test_fetch_github_info.py * No need to cover __name__ == __main__ block Co-authored-by: Dhruv Manilawala <[email protected]>
…heAlgorithms#3949) * fixes TheAlgorithms#3944 authentication error * Fixes: TheAlgorithms#3944 authentication error * Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards * run black formatter * Add USER_TOKEN constant and checks if empty, removes deprecated docstring * Add descriptive dict type hint, change headers format to f-string * Add Accept header * Fix pre-commit error * Fix pre-commit error * Add test for fetch_github_info * Remove test function from main file * Create test_fetch_github_info.py * Update test_fetch_github_info.py * Update test_fetch_github_info.py * No need to cover __name__ == __main__ block Co-authored-by: Dhruv Manilawala <[email protected]>
Fixes: #3944
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}
.