Skip to content

Fixes: #3944 authentication error #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 25, 2020
Merged

Fixes: #3944 authentication error #3949

merged 15 commits into from
Nov 25, 2020

Conversation

lawric1
Copy link
Contributor

@lawric1 lawric1 commented Nov 24, 2020

Fixes: #3944

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@lawric1 lawric1 requested a review from cclauss as a code owner November 24, 2020 12:19
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

Pull Request Report

@lawric1 Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request.

I have detected errors in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

What are node paths?

The report contain headings and a checklist where the items are paths to the class/function/parameter where the error is present. Node paths are double colon :: separated names and can be any of the following format:

  • Class path: [file_name]::[class_name]
  • Function path: [file_name]::[function_name]
  • Function parameter path: [file_name]::[function_name]::[parameter_name]
  • Method path: [file_name]::[class_name]::[function_name]
  • Method parameter path: [file_name]::[class_name]::[function_name]::[parameter_name]

Following functions require tests [doctest/unittest/pytest]:

  • web_programming/fetch_github_info.py::fetch_github_info

Relevant links:

@ghost ghost added require tests Tests [doctest/unittest/pytest] are required tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Nov 24, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 24, 2020
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the GitHub REST API documentation and apply the requested changes.

Combine the module-level docstring into one and that should come first, before any of the imports.

@ghost ghost added the awaiting changes A maintainer has requested changes to this PR label Nov 24, 2020
@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Nov 24, 2020
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 24, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 24, 2020
@lawric1
Copy link
Contributor Author

lawric1 commented Nov 24, 2020

Thanks for all the feedback, this is my first time contributing and i'm learning a lot

@ghost ghost added require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass labels Nov 25, 2020
@ghost ghost removed the require type hints https://docs.python.org/3/library/typing.html label Nov 25, 2020
@ghost ghost added require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass and removed require tests Tests [doctest/unittest/pytest] are required tests are failing Do not merge until tests pass labels Nov 25, 2020
@ghost ghost removed the require type hints https://docs.python.org/3/library/typing.html label Nov 25, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 25, 2020
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this and I hope you learned a lot. I added a test for this function using monkeypatch from pytest. If you have any doubt regarding the tests, please feel free to ask as it is difficult to write tests for web programming, especially for beginners.

@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label Nov 25, 2020
@dhruvmanila dhruvmanila merged commit 098f02b into TheAlgorithms:master Nov 25, 2020
@lawric1 lawric1 deleted the hotfix/fetch-github branch November 25, 2020 08:29
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
…heAlgorithms#3949)

* fixes TheAlgorithms#3944 authentication error
* Fixes: TheAlgorithms#3944 authentication error
* Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards
* run black formatter
* Add USER_TOKEN constant and checks if empty, removes deprecated docstring
* Add descriptive dict type hint, change headers format to f-string
* Add Accept header
* Fix pre-commit error
* Fix pre-commit error
* Add test for fetch_github_info
* Remove test function from main file
* Create test_fetch_github_info.py
* Update test_fetch_github_info.py
* Update test_fetch_github_info.py
* No need to cover __name__ == __main__ block

Co-authored-by: Dhruv Manilawala <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
…heAlgorithms#3949)

* fixes TheAlgorithms#3944 authentication error
* Fixes: TheAlgorithms#3944 authentication error
* Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards
* run black formatter
* Add USER_TOKEN constant and checks if empty, removes deprecated docstring
* Add descriptive dict type hint, change headers format to f-string
* Add Accept header
* Fix pre-commit error
* Fix pre-commit error
* Add test for fetch_github_info
* Remove test function from main file
* Create test_fetch_github_info.py
* Update test_fetch_github_info.py
* Update test_fetch_github_info.py
* No need to cover __name__ == __main__ block

Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
…heAlgorithms#3949)

* fixes TheAlgorithms#3944 authentication error
* Fixes: TheAlgorithms#3944 authentication error
* Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards
* run black formatter
* Add USER_TOKEN constant and checks if empty, removes deprecated docstring
* Add descriptive dict type hint, change headers format to f-string
* Add Accept header
* Fix pre-commit error
* Fix pre-commit error
* Add test for fetch_github_info
* Remove test function from main file
* Create test_fetch_github_info.py
* Update test_fetch_github_info.py
* Update test_fetch_github_info.py
* No need to cover __name__ == __main__ block

Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
…heAlgorithms#3949)

* fixes TheAlgorithms#3944 authentication error
* Fixes: TheAlgorithms#3944 authentication error
* Fixed docstring failure in pre-commit, Fixed request.get params to GitHub REST API standards
* run black formatter
* Add USER_TOKEN constant and checks if empty, removes deprecated docstring
* Add descriptive dict type hint, change headers format to f-string
* Add Accept header
* Fix pre-commit error
* Fix pre-commit error
* Add test for fetch_github_info
* Remove test function from main file
* Create test_fetch_github_info.py
* Update test_fetch_github_info.py
* Update test_fetch_github_info.py
* No need to cover __name__ == __main__ block

Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web_programming/fetch_github_info.py err
2 participants