Skip to content

Modified comments on upper.py ,made it more clean #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2020

Conversation

sethusankar
Copy link
Contributor

@sethusankar sethusankar commented Nov 13, 2020

Describe your change:

fixes: #3807

This is just a word change in the comments section to make the comments look more readable. No other issues are expected as a part of this change.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.

  • This pull request is all my own work -- I have not plagiarized.

  • I know that pull requests will not be merged if they fail the automated tests.

  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

  • All new Python files are placed inside an existing directory.

  • All filenames are in all lowercase characters with no spaces or dashes.

  • All functions and variable names follow Python naming conventions.

  • All function parameters and return values are annotated with Python type hints.

  • All functions have doctests that pass the automated testing.

  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation

  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{3807}.

Copy link
Contributor Author

@sethusankar sethusankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix issue 3807

@amaank404
Copy link
Contributor

add the following line to your PR body fixes: #3807 to link it to that issue

Co-authored-by: xcodz-dot <[email protected]>
Copy link
Contributor Author

@sethusankar sethusankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes: #3807

@amaank404
Copy link
Contributor

fixes: #3807

not here, edit your top PR body

@dhruvmanila dhruvmanila merged commit b31ed8c into TheAlgorithms:master Nov 18, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Modified comments on upper.py ,made it more clean

* Update strings/upper.py

Co-authored-by: xcodz-dot <[email protected]>

* Update upper.py

* Update upper.py

Co-authored-by: xcodz-dot <[email protected]>
Co-authored-by: Dhruv Manilawala <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Modified comments on upper.py ,made it more clean

* Update strings/upper.py

Co-authored-by: xcodz-dot <[email protected]>

* Update upper.py

* Update upper.py

Co-authored-by: xcodz-dot <[email protected]>
Co-authored-by: Dhruv Manilawala <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Modified comments on upper.py ,made it more clean

* Update strings/upper.py

Co-authored-by: xcodz-dot <[email protected]>

* Update upper.py

* Update upper.py

Co-authored-by: xcodz-dot <[email protected]>
Co-authored-by: Dhruv Manilawala <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Modified comments on upper.py ,made it more clean

* Update strings/upper.py

Co-authored-by: xcodz-dot <[email protected]>

* Update upper.py

* Update upper.py

Co-authored-by: xcodz-dot <[email protected]>
Co-authored-by: Dhruv Manilawala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the upper function of the string module exists a spelling error
3 participants