Skip to content

Quick sort with lomuto partition #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarineJoker
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@MarineJoker MarineJoker force-pushed the quick_sort_lomuto_partition branch 2 times, most recently from 5239af9 to 5e24cfd Compare November 11, 2020 09:42
@MarineJoker MarineJoker changed the title Quick sort lomuto partition Quick sort with lomuto partition Nov 13, 2020
@dhruvmanila dhruvmanila reopened this Dec 10, 2020
@ghost ghost added the enhancement This PR modified some existing files label Dec 10, 2020
@dhruvmanila
Copy link
Member

@algorithms-keeper review-all

@ghost ghost added the require tests Tests [doctest/unittest/pytest] are required label Dec 26, 2020
@ghost
Copy link

ghost commented Dec 26, 2020

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.


sorts/quick_sort_3_partition.py:1: As there is no test file in this pull request nor any test function or class in the file sorts/quick_sort_3_partition.py, please provide doctest for the function quick_sort_3partition

sorts/quick_sort_3_partition.py:59: Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: storeIndex


Content format: [file path]:[line number]: [message]

@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed require tests Tests [doctest/unittest/pytest] are required labels Dec 27, 2020
@MarineJoker
Copy link
Contributor Author

@algorithms-keeper review

@stale
Copy link

stale bot commented Feb 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Feb 2, 2021
@stale
Copy link

stale bot commented Feb 13, 2021

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Feb 13, 2021
@dhruvmanila dhruvmanila reopened this Feb 17, 2021
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Feb 17, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 17, 2021
@l3str4nge l3str4nge merged commit 78ddb46 into TheAlgorithms:master Feb 17, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* add quick sort algorithm with Lomuto partition

* fix(lomuto_partition): fix snake_case
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* add quick sort algorithm with Lomuto partition

* fix(lomuto_partition): fix snake_case
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* add quick sort algorithm with Lomuto partition

* fix(lomuto_partition): fix snake_case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants